Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual gas #2024

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Add virtual gas #2024

merged 1 commit into from
Jun 15, 2020

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Jun 15, 2020

No description provided.

Add virtual gas
a23a87a 
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu requested review from magik6k and whyrusleeping June 15, 2020 15:08
whyrusleeping
whyrusleeping approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, How do we actually add virtual charges to the code now?

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Jun 15, 2020

EIther in the price list, by adding on .WithVirtual(compute, storage).
Or: rt.ChargeGas(GasCharge{Name: "somethign"}.WithVirtual(compute, storage))

@Kubuxu Kubuxu merged commit 18cf7b0 into next Jun 15, 2020
@Kubuxu Kubuxu deleted the feat/virtual-gas branch June 15, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@magik6k magik6k Awaiting requested review from magik6k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kubuxu @whyrusleeping