Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy RLE+ #221

Merged
merged 12 commits into from
Dec 7, 2019
Merged

Lazy RLE+ #221

merged 12 commits into from
Dec 7, 2019

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Sep 20, 2019

License: MIT

whyrusleeping
whyrusleeping approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Have you done any benchmarks yet? or is that next?

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Sep 20, 2019

I still need encoding either way.

magik6k
magik6k reviewed Sep 23, 2019
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for wbitvec.Put

lib/rlepluslazy/bitvec.go Outdated Show resolved Hide resolved
lib/rlepluslazy/bitvec.go Outdated Show resolved Hide resolved
@Kubuxu Kubuxu force-pushed the misc/rlecrash branch 2 times, most recently from f9b464b to 32a1940 Compare December 7, 2019 14:48
Kubuxu and others added 9 commits December 7, 2019 15:48
@Kubuxu
Add lazy RLE+ decoding
c557aa2 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
More iterative algorithms
e5b3c47 
 - Add RunIterator and decoder from RLE
 - Add BitIterator and BitsFromRuns
 - Add BitsFromSlice
 - Add RunsFromBits

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Improve bitvector performance
9bf871e 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Improve benchmarks and fix bitvector iterator
3d6071e 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Add rle encoder
d3dfd8a 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Optimize and start wrapping it up
01c0a6e 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Remove old bitvector
794490c 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Improve complex code and comment it
353fef3 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
Replace rleplus with rlepluslazy
32a1940 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu changed the title [WIP] Lazy RLE+ Lazy RLE+ Dec 7, 2019
Jakub Sztandera added 2 commits December 7, 2019 15:51
Fix rleplus in actor code
6e4761c 
,
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
Fix typo in overflow check
80dbc25 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
whyrusleeping
whyrusleeping reviewed Dec 7, 2019
View reviewed changes
lib/rlepluslazy/rleplus.go Outdated
/*

type change struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

whyrusleeping
whyrusleeping approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nitpicks i mentioned to you, but otherwise this looks right

magik6k
magik6k reviewed Dec 7, 2019
View reviewed changes
lib/rlepluslazy/bitvec.go.bak Outdated
@@ -0,0 +1,63 @@
package rlepluslazy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove too

Some cleanup
71b973f 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu merged commit 4e36d91 into master Dec 7, 2019
@Kubuxu Kubuxu deleted the misc/rlecrash branch May 13, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k left review comments

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kubuxu @whyrusleeping @magik6k