conformance: various changes #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
raulk
commented
Sep 3, 2020
•
raulk
commented
- Tipset-class vectors: support sending from actor addresses. This is necessary for some test cases in migrate and enhance penalties subsuite from chain-validation. test-vectors#108, that were migrated from chain-validation. We test that these sends are disallowed.
- Sign secp256k1 messages with dummy signatures.
- Deprecate the puppet actor, which has now folded (partially) into the chaos actor. The chaos actor now occupies address t98.
|
@raulk why is this needed? You shouldnt actually be able to send messages from an actor, that should be disallowed. |
Yes, it's disallowed. But there are test cases in chain-validation that I've migrated over, that depend on this: https://github.com/filecoin-project/chain-validation/blob/master/suites/tipset/rewards_penalties.go#L133 |
raulk
force-pushed
the
conformance/tipset-actor-address
branch
from
d8d38ff to
8e7a8d8
Compare
|
Gas costs have changed as a result of now actually signing secp messages (despite the 0-filled signatures). There's additional storage cost for the extra 69 bytes (signature: 65 + header: 4). |
2 tasks
The puppet actor has been subsumed into the chaos actor and test-vector tests no longer use it.
raulk
changed the title
raulk
force-pushed
the
conformance/tipset-actor-address
branch
from
903a2c3 to
c723554
Compare
2 tasks
magik6k
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.