update ffi to code with blst fixes #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand how we're building this, but will we need to also update the |
|
well, the blst repo apparently contains a bunch of different things, when we import it in go, we don't use the code that actually contains the fix. The rust code is what imports the c++ code that has the code being fixed. So our imports in the go side don't really change. At least, as far as i understand. |
|
yeah, i don't understand either...would there be an argument to "update anyway"? idkkk. |
|
Yeah this is the "right" way for the moment, though it will get better soon(tm) |
|
does this fix #3826 ? |
Kubuxu
approved these changes
Sep 25, 2020
magik6k
approved these changes
Sep 26, 2020
Probably not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.