Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small chain export optimization #4536

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Small chain export optimization #4536

merged 3 commits into from
Oct 22, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 22, 2020

Adds a better test for #4330 (which is already approved)

@magik6k magik6k mentioned this pull request Oct 22, 2020
Closed
@magik6k magik6k force-pushed the zgfzgf-fix-chain-export branch from 71bd99a to ae04f30 Compare October 22, 2020 14:01
@magik6k magik6k merged commit 6b9a4c4 into master Oct 22, 2020
@magik6k magik6k deleted the zgfzgf-fix-chain-export branch October 22, 2020 15:36
schomatis
schomatis reviewed Oct 22, 2020
View reviewed changes
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

git revert b7726c4ca83d632f15bc311d53281a5ad2a9929d
go test ./chain/store -run TestChainExportImportFull -count=10

This passes roughly 9-10 out of 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schomatis schomatis schomatis left review comments

@Kubuxu Kubuxu Kubuxu approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magik6k @Kubuxu @schomatis @zgfzgf