Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand sched-diag; Command to abort sealing calls #4804

Merged
merged 5 commits into from
Nov 12, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 11, 2020

No description provided.

@magik6k magik6k force-pushed the feat/storage-retwait-cleanup branch from 85e8483 to 8ac4957 Compare November 11, 2020 16:42
@magik6k magik6k requested a review from arajasek November 11, 2020 16:42
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

var sealingAbortCmd = &cli.Command{
Name: "abort",
Usage: "Abort a running job",
ArgsUsage: "[call id]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna call this callid instead, it kinda sounds like it takes 2 separate arguments call and id otherwise,

@arajasek arajasek merged commit 3a39863 into master Nov 12, 2020
@arajasek arajasek deleted the feat/storage-retwait-cleanup branch November 12, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants