Chore/blockstore nits #4813
Merged
Chore/blockstore nits #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no practical way to do GC against the chainstore given the current state of affairs: remove all GC-related types for the time being.
ribasushi
force-pushed
the
chore/blockstore_nits
branch
from
f2ba17a to
29817b6
Compare
Stebalien
approved these changes
Nov 12, 2020
Kubuxu
approved these changes
Nov 13, 2020
|
@Kubuxu what's the "protocol" for merging such PRs? Just checking whether it is waiting on something from my side... |
|
Nah, it was waiting for someone to feel like pressing a button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landing a few nits from a larger semi-abandoned refactor.