Fix cid recording issue #4874
Merged
Fix cid recording issue #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
hannahhoward
force-pushed
the
feat/update-markets-fix-cid-recording
branch
from
51c1c79 to
6118e88
Compare
hannahhoward
force-pushed
the
feat/update-markets-fix-cid-recording
branch
from
6118e88 to
a2abeef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
fix #4856
Implementation
See corresponding dependent PR -- filecoin-project/go-data-transfer#118
The only substantive change here is that we need to setup a directory in which to place these cid recordings, setup us as a "data-transfer" subdirectory under the repo path.