fetch size according to RegisteredSealProof #5167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acautman
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
acautman
changed the title
magik6k
reviewed
Dec 10, 2020
| @@ -123,6 +149,12 @@ func (r *Remote) AcquireSector(ctx context.Context, s storage.SectorRef, existin | |||
| } | |||
| defer releaseStorage() | |||
|
|
|||
| var iosize uint64 = 0 | |||
| ssize, err := GetIoSizeByProofType(s.ProofType) | |||
There was a problem hiding this comment.
I'd do iosize = 32 << 10; if s.ProofType.SectorSize() > 8 << 20 {iosize=1<<20}
There was a problem hiding this comment.
(this way we can drop GetIoSizeByProofType from above)
| @@ -276,12 +308,57 @@ func (r *Remote) fetch(ctx context.Context, url, outname string) error { | |||
| case "application/x-tar": | |||
| return tarutil.ExtractTar(resp.Body, outname) | |||
| case "application/octet-stream": | |||
| return files.WriteTo(files.NewReaderFile(resp.Body), outname) | |||
| return WriteWithSize(files.NewReaderFile(resp.Body), outname, iosize) | |||
There was a problem hiding this comment.
This used the files api to make things simpler. Instead of duplicating the code below, we can just do
Suggested change
| return WriteWithSize(files.NewReaderFile(resp.Body), outname, iosize) | |
| f, err := os.Create(outname) | |
| defer f.Close() | |
| if err != nil { | |
| return err | |
| } | |
| _, err = io.CopyBuffer(f, resp.Body, make([]byte, iosize)) | |
| if err != nil { | |
| return err | |
| } | |
| return nil |
|
(applied suggestions in #5177) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write size according to RegisteredSealProof，default 32K size may result in low performance，when sector size is 512M/32G/64G，increase write size to 1M