Multicore AddPiece CommP #5320
Merged
Multicore AddPiece CommP #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you 100% that pieces can be combined and the resulting CID will be the same? Do we have tests for this? |
Yep, It's a simple binary tree under the hood. (The CID in TestAddPiece512M was generated in a single call. Also, we are already doing this chunking on master, this is just making things run in parallel) |
Kubuxu
approved these changes
Jan 11, 2021
magik6k
force-pushed
the
feat/multicore-addpiece
branch
from
524042f to
5462ecf
Compare
|
(tested manually on my miner, works, and it's really fast there too) |
|
@magik6k Should we change resource that addpiece needs in sector-storage/resources.go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
BenchmarkAddPiece512M-32 1 7034478758 ns/op 75.72 MB/sAfter:
BenchmarkAddPiece512M-32 2 916931366 ns/op 580.93 MB/s(on AMD TR2950X)