Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sector termination support #5341

Merged
merged 18 commits into from
Jan 14, 2021
Merged

Sector termination support #5341

merged 18 commits into from
Jan 14, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jan 13, 2021 •
edited
Loading

TODO:

  • Don't declare in proving window (v3 actors will disallow that)
  • Fix tests
  • CLI
  • Node tests
  • Test in pond
  • Test on mainnet

Closes #3885

@magik6k magik6k changed the title Initial sector termination support Sector termination support Jan 13, 2021
Stebalien
Stebalien approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some nits (especially around error cases) but this otherwise looks sound.

extern/storage-sealing/states_proving.go Show resolved Hide resolved
extern/storage-sealing/terminate_batch.go Outdated Show resolved Hide resolved
extern/storage-sealing/terminate_batch.go Outdated Show resolved Hide resolved
extern/storage-sealing/terminate_batch.go Outdated Show resolved Hide resolved
extern/storage-sealing/terminate_batch.go Outdated Show resolved Hide resolved
@magik6k magik6k marked this pull request as ready for review January 14, 2021 15:06
@magik6k magik6k requested a review from Stebalien January 14, 2021 15:06
Stebalien
Stebalien requested changes Jan 14, 2021
View reviewed changes
extern/storage-sealing/terminate_batch.go Outdated Show resolved Hide resolved
extern/storage-sealing/terminate_batch.go Outdated Show resolved Hide resolved
extern/storage-sealing/terminate_batch.go Outdated Show resolved Hide resolved
@magik6k
Copy link
Contributor Author

magik6k commented Jan 14, 2021

works on mainnet

@magik6k magik6k merged commit 476df99 into master Jan 14, 2021
@magik6k magik6k deleted the feat/sectors-terminate branch January 14, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose an API/CLI for storage miners to terminate a sector
2 participants
@magik6k @Stebalien