Implement Event observer and Settings for 3rd party dep injection #5693
Conversation
Makefile
Outdated
| lotus-sentinel: $(BUILD_DEPS) | ||
| rm -f lotus-sentinel | ||
| go build -o lotus-sentinel ./cmd/lotus-sentinel | ||
| .PHONY: lotus-keygen |
There was a problem hiding this comment.
| .PHONY: lotus-keygen | |
| .PHONY: lotus-sentinel |
cmd/lotus-sentinel/daemon.go
Outdated
| }, | ||
| } | ||
|
|
||
| func ImportChain(ctx context.Context, r repo.Repo, fname string, snapshot bool) (err error) { |
There was a problem hiding this comment.
I'd try to deduplicate this with the 'normal' daemon
There was a problem hiding this comment.
Any preference for where this should live? In order for other packages to use it, we'll have to move it out of this file since it's in package main -- my first thought was the repo package.
This could also just be dropped as a feature from the lotus-sentinel binary and users would be required to perform the import with the lotus bin, thoughts @iand?
There was a problem hiding this comment.
Would prefer not to have to make the user switch between binaries for this task. Let's find a new home for this function in a suitable lotus package.
node/builder.go
Outdated
| @@ -14,6 +14,7 @@ import ( | |||
| "github.com/filecoin-project/lotus/chain/store" | |||
| "github.com/filecoin-project/lotus/chain/vm" | |||
| "github.com/filecoin-project/lotus/chain/wallet" | |||
| api2 "github.com/filecoin-project/lotus/cmd/lotus-sentinel/api" | |||
There was a problem hiding this comment.
| api2 "github.com/filecoin-project/lotus/cmd/lotus-sentinel/api" | |
| sentinelapi "github.com/filecoin-project/lotus/cmd/lotus-sentinel/api" |
There was a problem hiding this comment.
Pretty happy with how this turned out. Now the question is whether the binary needs to live in the lotus repo or can it live in sentinel's? The extension points and exposure of things like ImportChain obviously have to stay in Lotus but once we have those it seems by moving the binary elsewhere we could avoid Lotus depending on the all the visor and postgres packages. Plus we get to decouple the development processes of the two projects.
cmd/lotus-sentinel/daemon.go
Outdated
| }, | ||
| } | ||
|
|
||
| func ImportChain(ctx context.Context, r repo.Repo, fname string, snapshot bool) (err error) { |
There was a problem hiding this comment.
Would prefer not to have to make the user switch between binaries for this task. Let's find a new home for this function in a suitable lotus package.
|
I'm going to extract the lotus-sentinel binary code to the visor repo and modify this PR only to contain the changes required to make that work -- I suspect they will be minimal (sorry for the churn) |
frrist
changed the title
lotus-sentinel binary for sentinel integration
|
Converting to a draft as this will require more changes than I anticipated. The other half lives here: filecoin-project/lily#408 |
- allows tipset apply and revert to be observed
- motivating use case running a lotus-sentinel node
What