Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallback chainstore #6003

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fix fallback chainstore #6003

merged 1 commit into from
Apr 9, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 9, 2021

Fixes #5975

@magik6k magik6k requested a review from ribasushi April 9, 2021 13:32
arajasek
arajasek approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My node no longer crashes when doing this, so approved.

ribasushi
ribasushi approved these changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's 🚢

@ribasushi
Copy link
Collaborator

@arajasek can we backport this to 0.7? it's fixing a regression arguably...

@magik6k magik6k merged commit 88bdb59 into master Apr 9, 2021
@magik6k magik6k deleted the fix/fbs-di branch April 9, 2021 23:58
@firesWu
Copy link
Contributor

firesWu commented Apr 11, 2021 •
edited
Loading

I use this PR and add env LOTUS_ENABLE_CHAINSTORE_FALLBACK =1
When I exec delete-obj some cid and restart lotus-daemon, lotus still report error which is 'block not found'.
I fallback to 1.5.0 version, lotus sync normally. @magik6k

@magik6k magik6k mentioned this pull request Apr 13, 2021
Closed
69 tasks
@rickiey rickiey mentioned this pull request Apr 16, 2021
Open
@donnol donnol mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

@ribasushi ribasushi ribasushi approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] No longer possible to start with LOTUS_ENABLE_CHAINSTORE_FALLBACK=1
4 participants
@magik6k @ribasushi @firesWu @arajasek