Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-graphsync v0.8.0 #6375

Closed
wants to merge 1 commit into from
Closed

Conversation

hannahhoward
Copy link
Contributor

Goals

Good news: The latest version of go-graphync and go-ipld-prime contains an important optimization to remove a bunch of unneccesary hashing when reading from local blockstores, which should cut down significantly on CPU usage
Bad news: The latest versions of these libraries contain a some important, but very breaking changes to syntax.
Good news: I'm updating them all the way to Lotus! And also, in most cases, from the point of view of the consuming libraries, they're simplifications.

Implementation

  • Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.
  • Update other dependent libraries with SHA updates
  • had to also update libp2p-quic-transport to v0.10.0 cause of libp2p updates
  • Fix syntax changes which are mostly to:
    • dagcbor Encode / Decode function name
    • use of linksystem over loader + storer.

Background

For Discussion

Merge Blocked ON:
filecoin-project/go-data-transfer#212
filecoin-project/go-multistore#3
filecoin-project/go-fil-markets#550

Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.
@hannahhoward hannahhoward force-pushed the feat/update-graphsync-v0.8.0 branch from 3718c92 to b26b3cb Compare June 1, 2021 22:38
@magik6k magik6k requested review from Stebalien and dirkmc and removed request for Stebalien June 1, 2021 22:39
@magik6k
Copy link
Contributor

magik6k commented Jun 2, 2021

(marking as draft for now as still needs deps to be updated)

@magik6k magik6k marked this pull request as draft June 2, 2021 10:02
@jennijuju jennijuju added this to the v1.11.x milestone Jun 14, 2021
@jennijuju jennijuju added the P2 P2: Should be resolved label Jun 25, 2021
@BigLep
Copy link
Member

BigLep commented Jun 30, 2021

Per internal conversations, this PR is blocked until key end-of-July deliverables.

@ribasushi
Copy link
Collaborator

ribasushi commented Jul 7, 2021

this PR is blocked until key end-of-July deliverables.

@BigLep is it possible to add a a few links enumerating parallel efforts that are logistical blockers to this PR?

@Stebalien Stebalien removed their request for review July 7, 2021 18:36
@jennijuju jennijuju modified the milestones: 1.11.1 , v1.11.2 Jul 27, 2021
@jennijuju jennijuju modified the milestones: v1.11.2, v1.11.3 Aug 16, 2021
@hannahhoward
Copy link
Contributor Author

superseded by #7197

@Kubuxu Kubuxu deleted the feat/update-graphsync-v0.8.0 branch November 25, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 P2: Should be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants