Always flush when timer goes off

[arajasek]

Might add a test, but here's a PR.

Fixes #6541

[BigLep]

Is there a reason we wouldn't add a test here?

[jennijuju]

I think the same logic change should be applied to pre commit batcher too.

[magik6k]

I think the same logic change should be applied to pre commit batcher too.

In the precommit batcher the min batch size has a slightly different meaning as we haven't committed to publishing those sectors yet, and sending individual precommits makes no sense, so the only use for MinBatch is not sending anything

We might want to have Commit / PreCommitMinBatch config vars have different names tho, to make sure it's clear that they are doing quite different things

[arajasek]

I think the same logic change should be applied to pre commit batcher too.

In the precommit batcher the min batch size has a slightly different meaning as we haven't committed to publishing those sectors yet, and sending individual precommits makes no sense, so the only use for MinBatch is not sending anything

We might want to have Commit / PreCommitMinBatch config vars have different names tho, to make sure it's clear that they are doing quite different things

Aren't there two cases when we do want to publish sectors, though:

• if a ticket is expiring (and we're risking losing the PC work)
• if a deal included in the sector is approaching activation

[arajasek]

Summary: makes sense to just remove MinPreCommitBatch entirely -- if the timer goes off, we just batch and precommit whatever we have.

Thanks @jennijuju!