fix ticket expiration check #6635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loops to retry GetTicket when retrying PreCommit1
|
this large number of cycles will cause the kvlog to increase rapidly |
magik6k
reviewed
Jun 30, 2021
arajasek
reviewed
Jul 1, 2021
| @@ -105,48 +105,66 @@ func checkTicketExpired(ticket, head abi.ChainEpoch) bool { | |||
| return head-ticket > MaxTicketAge // TODO: allow configuring expected seal durations | |||
| } | |||
|
|
|||
| func (m *Sealing) getTicket(ctx statemachine.Context, sector SectorInfo) (abi.SealRandomness, abi.ChainEpoch, error) { | |||
| func checkProveCommitExpired(preCommitEpoch, msd abi.ChainEpoch, currEpoch abi.ChainEpoch) bool { | |||
There was a problem hiding this comment.
should be called checkPreCommitExpired?
There was a problem hiding this comment.
This is checking if we're past the time to prove (not precommit) a sector, so I think this name is correct
fix log Co-authored-by: Aayush Rajasekaran <[email protected]>
fix sector precommitted but expired judgment Co-authored-by: Łukasz Magiera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ticket expiration check, otherwise it may cause a large number of loops to retry GetTicket when retrying PreCommit1；
Because there may be C1 and C2 execution failures, and after they retries more than a certain number of times, will cause PreCommit1 to be re-executed, and now it is the submission period of 30, so it will cause an endless loop of repeated execution of GetTicket.