Reuse timers in sealing batch logic #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
changed the title
magik6k
approved these changes
Jun 30, 2021
| now := time.Now() | ||
|
|
||
| b.lk.Lock() | ||
| defer b.lk.Unlock() | ||
|
|
||
| if len(b.todo) == 0 { | ||
| return nil | ||
| return maxWait |
There was a problem hiding this comment.
Ideally we wouldn't be resetting the timer here, but I don't think this micro-optimization is worth the added complexity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original batchwait would cause a timer instance to be created for each round of the for loop。