Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitstore shed utils #6811

Merged
merged 28 commits into from
Jul 26, 2021
Merged

splitstore shed utils #6811

merged 28 commits into from
Jul 26, 2021

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Jul 21, 2021

Adds a lotus-shed splitstore command with some utilities:

  • rollback command, which rolls back the splitstore.
  • check which performs a health check.
  • info which prints some basic information.

Closes #6737

@vyzo vyzo added the team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs label Jul 21, 2021
@vyzo vyzo force-pushed the feat/splitstore-shed-utils branch from 455e6f6 to be83bf2 Compare July 21, 2021 11:37
@magik6k
Copy link
Contributor

magik6k commented Jul 22, 2021

Would be nice to also have a light info command which would get you blockstore sizes, and maybe some state (e.g. epochs in hotstore + maybe some things which could be useful for debugging user nodes)

@vyzo
Copy link
Contributor Author

vyzo commented Jul 22, 2021

sure!

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane so far.

cmd/lotus-shed/splitstore.go Outdated Show resolved Hide resolved
cmd/lotus-shed/splitstore.go Outdated Show resolved Hide resolved
cmd/lotus-shed/splitstore.go Outdated Show resolved Hide resolved
cmd/lotus-shed/splitstore.go Outdated Show resolved Hide resolved
cmd/lotus-shed/splitstore.go Show resolved Hide resolved
@jacobheun
Copy link
Contributor

@vyzo can you ensure that https://github.com/filecoin-project/lotus/blob/master/blockstore/splitstore/README.md is updated to include a section on how to rollback when this is ready?

@vyzo
Copy link
Contributor Author

vyzo commented Jul 22, 2021

ah yes, thanks for reminding me -- will do.

@vyzo vyzo force-pushed the feat/splitstore-shed-utils branch from 492d55e to 5b08791 Compare July 22, 2021 19:50
@vyzo
Copy link
Contributor Author

vyzo commented Jul 22, 2021

rebased on master.

@vyzo vyzo force-pushed the feat/splitstore-shed-utils branch from 5b08791 to ce6f410 Compare July 25, 2021 06:01
@vyzo
Copy link
Contributor Author

vyzo commented Jul 25, 2021

rebased on master.

@vyzo vyzo force-pushed the feat/splitstore-shed-utils branch from 63e8fd2 to 21bb2bd Compare July 25, 2021 08:25
@vyzo vyzo mentioned this pull request Jul 25, 2021
@vyzo vyzo marked this pull request as ready for review July 26, 2021 06:51
@vyzo vyzo requested a review from a team as a code owner July 26, 2021 06:51
@vyzo vyzo requested review from raulk and magik6k July 26, 2021 06:51
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit about perms

api/api_full.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit 5048c3f into master Jul 26, 2021
@magik6k magik6k deleted the feat/splitstore-shed-utils branch July 26, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Splitstore: Copy hot store data to cold store for rollbacks
4 participants