Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a very verbose -vv flag to lotus and lotus-miner. #6888

Merged
merged 6 commits into from
Jul 27, 2021

Conversation

raulk
Copy link
Member

@raulk raulk commented Jul 27, 2021

This helps debug issues like the Miner Runtime Architecture segregation issues reported here: #6861, where there might be a mix up of environment variables, repos, etc. leading to the wrong API endpoints being used.

@raulk raulk requested review from nonsense, magik6k and a team July 27, 2021 13:26
jennijuju
jennijuju previously approved these changes Jul 27, 2021
@jennijuju
Copy link
Member

missing make docsgen-cli

@jennijuju jennijuju self-requested a review July 27, 2021 13:42
@jennijuju
Copy link
Member

jennijuju commented Jul 27, 2021

id suggest to have a separate cli, like lotus version -v or adding lotus api-info instead of adding a global option

@jennijuju jennijuju dismissed their stale review July 27, 2021 13:45

approved by accident

@raulk
Copy link
Member Author

raulk commented Jul 27, 2021

@jennijuju I've thought this as a general CLI diagnostics flag. Right now we're printing API endpoints, but we can print other things, like file/directory paths, polling intervals, counts, etc.

For the API endpoint tracing, I don't think putting it behind a command is the right call, because we want to trace what's being used in the command we are running right now.

Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think of "VeryVerbose" as the standard name for this and it has the benefit of matching "vv" but this is not very important.

@raulk raulk force-pushed the feat/cli-super-verbose branch from 56f13a5 to b04fb75 Compare July 27, 2021 19:49
@raulk
Copy link
Member Author

raulk commented Jul 27, 2021

@ZenGround0 agree. Changed the terminology.

@raulk raulk changed the title add a super verbose -vv flag to lotus and lotus-miner. add a very verbose -vv flag to lotus and lotus-miner. Jul 27, 2021
@raulk raulk merged commit 505bc58 into master Jul 27, 2021
@raulk raulk deleted the feat/cli-super-verbose branch July 27, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants