Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov Projects #7147

Merged
merged 9 commits into from
Aug 20, 2021
Merged

Codecov Projects #7147

merged 9 commits into from
Aug 20, 2021

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Aug 20, 2021

WIP

@ZenGround0 ZenGround0 marked this pull request as ready for review August 20, 2021 14:40
@ZenGround0 ZenGround0 requested a review from a team as a code owner August 20, 2021 14:40
@filecoin-project filecoin-project deleted a comment from codecov bot Aug 20, 2021
.codecov.yml Outdated
chain:
target: auto
threshold: 0.1%
informational: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably sufficient to just set this to false -- we could subdivide into smaller projects, but I think they'd all still be "required" instead of "informational"

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #7147 (c7aac60) into master (5bdc186) will decrease coverage by 11.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7147       +/-   ##
===========================================
- Coverage   46.35%   34.69%   -11.67%     
===========================================
  Files         500      682      +182     
  Lines       53488    79742    +26254     
===========================================
+ Hits        24795    27663     +2868     
- Misses      24367    46438    +22071     
- Partials     4326     5641     +1315     
Impacted Files Coverage Δ
extern/storage-sealing/terminate_batch.go 21.56% <0.00%> (-38.73%) ⬇️
extern/storage-sealing/states_proving.go 6.06% <0.00%> (-19.70%) ⬇️
itests/kit/node_miner.go 61.03% <0.00%> (-19.49%) ⬇️
extern/storage-sealing/sealing.go 65.85% <0.00%> (-8.54%) ⬇️
storage/miner_sealing.go 77.50% <0.00%> (-7.50%) ⬇️
storage/wdpost_sched.go 75.24% <0.00%> (-5.95%) ⬇️
extern/storage-sealing/fsm_events.go 48.73% <0.00%> (-5.89%) ⬇️
chain/events/events.go 69.38% <0.00%> (-4.09%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
miner/miner.go 50.00% <0.00%> (-3.32%) ⬇️
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bdc186...c7aac60. Read the comment docs.

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do what we want it to do. Whether the changes accurately reflect what happens in a PR is TBD...

@ZenGround0 ZenGround0 merged commit 57337c1 into master Aug 20, 2021
@ZenGround0 ZenGround0 deleted the chore/codecov-projects branch August 20, 2021 16:53
@BigLep
Copy link
Member

BigLep commented Aug 24, 2021

For context, this is part of #7164

@BigLep BigLep linked an issue Aug 24, 2021 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistently have "CI Green" for Lotus - (Internal improvements program)
3 participants