Randomness: Move getters from ChainAPI to StateAPI #7322

arajasek · 2021-09-13T09:29:36Z

These arguably always belonged here, but especially so now that we versioned behaviour

magik6k

Should bump the v1 fullnode api version

arajasek · 2021-09-13T15:42:19Z

Should bump the v1 fullnode api version

Yessir, done

magik6k · 2021-09-14T08:56:36Z

The paych test fail looks concerning:

2021-09-13T15:43:54.528Z	ERROR	storageminer	storage/wdpost_run.go:874	estimating gas	{"error": "estimating gas used: message execution failed: exit 16, reason: post commit randomness mismatched (RetCode=16)", "errorVerbose": "estimating gas used:\n    github.com/filecoin-project/lotus/node/impl/full.(*GasModule).GasEstimateMessageGas\n        /home/circleci/project/node/impl/full/gas.go:329\n  - message execution failed: exit 16, reason: post commit randomness mismatched (RetCode=16):\n    github.com/filecoin-project/lotus/node/impl/full.gasEstimateGasLimit\n        /home/circleci/project/node/impl/full/gas.go:295"}
2021-09-13T15:43:54.529Z	WARN	vm	vm/runtime.go:350	Abortf: post commit randomness mismatched
2021-09-13T15:43:54.529Z	WARN	vm	vm/runtime.go:149	VM.Call failure in call from: f0102 to f01000: post commit randomness mismatched (RetCode=16):
    github.com/filecoin-project/specs-actors/v5/actors/builtin/miner.Actor.SubmitWindowedPoSt.func1
        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/miner/miner_actor.go:409
2021-09-13T15:43:54.529Z	WARN	vm	vm/vm.go:537	Send actor error	{"from": "f0102", "to": "f01000", "nonce": 1, "method": "5", "height": "684", "error": "post commit randomness mismatched (RetCode=16):\n    github.com/filecoin-project/specs-actors/v5/actors/builtin/miner.Actor.SubmitWindowedPoSt.func1\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/miner/miner_actor.go:409"}
2021-09-13T15:43:54.529Z	ERROR	storageminer	storage/wdpost_run.go:186	submit window post failed: pushing message to mpool:
    github.com/filecoin-project/lotus/storage.(*WindowPoStScheduler).submitPoStMessage
        /home/circleci/project/storage/wdpost_run.go:836
  - GasEstimateMessageGas error:
    github.com/filecoin-project/lotus/node/impl/full.(*MpoolAPI).MpoolPushMessage
        /home/circleci/project/node/impl/full/mpool.go:160
  - estimating gas used:
    github.com/filecoin-project/lotus/node/impl/full.(*GasModule).GasEstimateMessageGas
        /home/circleci/project/node/impl/full/gas.go:329
  - message execution failed: exit 16, reason: post commit randomness mismatched (RetCode=16):
    github.com/filecoin-project/lotus/node/impl/full.gasEstimateGasLimit
        /home/circleci/project/node/impl/full/gas.go:295

codecov · 2021-09-14T22:12:39Z

Codecov Report

Merging #7322 (1d6db30) into master (aae9bf3) will increase coverage by 0.04%.
The diff coverage is 46.42%.

@@            Coverage Diff             @@
##           master    #7322      +/-   ##
==========================================
+ Coverage   39.15%   39.20%   +0.04%     
==========================================
  Files         614      614              
  Lines       65001    65009       +8     
==========================================
+ Hits        25451    25485      +34     
+ Misses      35140    35124      -16     
+ Partials     4410     4400      -10

Impacted Files	Coverage Δ
api/api_full.go	`47.36% <ø> (ø)`
api/v0api/v1_wrapper.go	`2.22% <0.00%> (-0.11%)`	⬇️
api/version.go	`80.00% <ø> (ø)`
chain/gen/gen.go	`66.06% <0.00%> (ø)`
extern/storage-sealing/mocks/api.go	`17.84% <0.00%> (ø)`
extern/storage-sealing/sealing.go	`74.39% <ø> (ø)`
node/impl/full/chain.go	`12.95% <ø> (-1.22%)`	⬇️
storage/miner.go	`71.59% <ø> (ø)`
node/impl/full/state.go	`34.91% <75.00%> (+0.77%)`	⬆️
chain/vm/runtime.go	`54.22% <100.00%> (+2.02%)`	⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae9bf3...1d6db30. Read the comment docs.

arajasek · 2021-09-14T23:30:58Z

The paych test fail looks concerning:

2021-09-13T15:43:54.528Z	ERROR	storageminer	storage/wdpost_run.go:874	estimating gas	{"error": "estimating gas used: message execution failed: exit 16, reason: post commit randomness mismatched (RetCode=16)", "errorVerbose": "estimating gas used:\n    github.com/filecoin-project/lotus/node/impl/full.(*GasModule).GasEstimateMessageGas\n        /home/circleci/project/node/impl/full/gas.go:329\n  - message execution failed: exit 16, reason: post commit randomness mismatched (RetCode=16):\n    github.com/filecoin-project/lotus/node/impl/full.gasEstimateGasLimit\n        /home/circleci/project/node/impl/full/gas.go:295"}
2021-09-13T15:43:54.529Z	WARN	vm	vm/runtime.go:350	Abortf: post commit randomness mismatched
2021-09-13T15:43:54.529Z	WARN	vm	vm/runtime.go:149	VM.Call failure in call from: f0102 to f01000: post commit randomness mismatched (RetCode=16):
    github.com/filecoin-project/specs-actors/v5/actors/builtin/miner.Actor.SubmitWindowedPoSt.func1
        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/miner/miner_actor.go:409
2021-09-13T15:43:54.529Z	WARN	vm	vm/vm.go:537	Send actor error	{"from": "f0102", "to": "f01000", "nonce": 1, "method": "5", "height": "684", "error": "post commit randomness mismatched (RetCode=16):\n    github.com/filecoin-project/specs-actors/v5/actors/builtin/miner.Actor.SubmitWindowedPoSt.func1\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/miner/miner_actor.go:409"}
2021-09-13T15:43:54.529Z	ERROR	storageminer	storage/wdpost_run.go:186	submit window post failed: pushing message to mpool:
    github.com/filecoin-project/lotus/storage.(*WindowPoStScheduler).submitPoStMessage
        /home/circleci/project/storage/wdpost_run.go:836
  - GasEstimateMessageGas error:
    github.com/filecoin-project/lotus/node/impl/full.(*MpoolAPI).MpoolPushMessage
        /home/circleci/project/node/impl/full/mpool.go:160
  - estimating gas used:
    github.com/filecoin-project/lotus/node/impl/full.(*GasModule).GasEstimateMessageGas
        /home/circleci/project/node/impl/full/gas.go:329
  - message execution failed: exit 16, reason: post commit randomness mismatched (RetCode=16):
    github.com/filecoin-project/lotus/node/impl/full.gasEstimateGasLimit
        /home/circleci/project/node/impl/full/gas.go:295

should be fixed

arajasek requested a review from a team as a code owner September 13, 2021 09:29

arajasek force-pushed the asr/drand-state branch from 4256778 to 87b68e9 Compare September 13, 2021 15:24

magik6k reviewed Sep 13, 2021

View reviewed changes

arajasek force-pushed the asr/drand-state branch from 87b68e9 to 91a7be2 Compare September 13, 2021 15:41

Randomness: Move getters from ChainAPI to StateAPI

1d6db30

arajasek force-pushed the asr/drand-state branch from 91a7be2 to 1d6db30 Compare September 14, 2021 22:03

magik6k approved these changes Sep 21, 2021

View reviewed changes

magik6k merged commit 2437a41 into master Sep 21, 2021

magik6k deleted the asr/drand-state branch September 21, 2021 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Randomness: Move getters from ChainAPI to StateAPI #7322

Randomness: Move getters from ChainAPI to StateAPI #7322

arajasek commented Sep 13, 2021

magik6k left a comment

arajasek commented Sep 13, 2021

magik6k commented Sep 14, 2021

codecov bot commented Sep 14, 2021 •

edited

Loading

arajasek commented Sep 14, 2021

Randomness: Move getters from ChainAPI to StateAPI #7322

Randomness: Move getters from ChainAPI to StateAPI #7322

Conversation

arajasek commented Sep 13, 2021

magik6k left a comment

Choose a reason for hiding this comment

arajasek commented Sep 13, 2021

magik6k commented Sep 14, 2021

codecov bot commented Sep 14, 2021 • edited Loading

Codecov Report

arajasek commented Sep 14, 2021

codecov bot commented Sep 14, 2021 •

edited

Loading