Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sealing: Improve scheduling of ready work #7335

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 15, 2021

Right now if we have a task which is preparing, another task which is behind it that is ready, and there is nothing currently executing we won't start the ready task even though we could. This PR makes that logic smarter.

Might even work right now; but still some things remain todo:

  • Make sure that ready-scheduled tasks are executed in correct order (I think this is fine??)
  • Ready checks for more task types
    • Can be a follow up PR
  • Run on a miner for a while
  • Run on some more miner setups

On top of #7334

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #7335 (9af82f2) into master (fc10281) will increase coverage by 0.02%.
The diff coverage is 77.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7335      +/-   ##
==========================================
+ Coverage   39.54%   39.56%   +0.02%     
==========================================
  Files         616      616              
  Lines       65295    65360      +65     
==========================================
+ Hits        25818    25858      +40     
- Misses      34980    35012      +32     
+ Partials     4497     4490       -7     
Impacted Files Coverage Δ
extern/sector-storage/sched.go 84.71% <ø> (ø)
extern/sector-storage/sched_worker.go 77.84% <75.38%> (-1.28%) ⬇️
extern/sector-storage/sched_resources.go 85.29% <100.00%> (+0.91%) ⬆️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
miner/miner.go 52.31% <0.00%> (-3.32%) ⬇️
extern/sector-storage/stores/local.go 56.81% <0.00%> (-1.99%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc10281...9af82f2. Read the comment docs.

Base automatically changed from chore/sched-worklk to master September 16, 2021 10:08
@magik6k magik6k force-pushed the feat/sched-ready-work branch from 033a925 to b87142e Compare October 3, 2021 09:28
@jennijuju jennijuju added the SPX label Oct 5, 2021
@jennijuju jennijuju added this to the v1.13.1 milestone Oct 5, 2021
@magik6k magik6k marked this pull request as ready for review October 6, 2021 14:01
@magik6k magik6k requested a review from a team as a code owner October 6, 2021 14:01
@magik6k magik6k merged commit aed6e8d into master Oct 7, 2021
@magik6k magik6k deleted the feat/sched-ready-work branch October 7, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants