Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go-fil-markets v1.13.0 #7441

Closed
wants to merge 2 commits into from
Closed

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Oct 4, 2021

This version of go-fil-markets has a fix that makes restarting data transfers more reliable.

TODO:

  • Storage deal restart testing
    OLD: lotus v1.11.3
    NEW: this branch
    • New client / Old server ✅
    • New client / New server ✅
    • Old client / New server ✅
  • Release go-ipld-prime v0.12.3 and bubble up to lotus
  • Release go-graphsync v0.10.0 (currently this branch is using v0.10.0-rc3)

@dirkmc dirkmc changed the title use [email protected] use go-fil-markets v1.13.0 Oct 4, 2021
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #7441 (16973bc) into master (fc10281) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7441      +/-   ##
==========================================
- Coverage   39.54%   39.51%   -0.03%     
==========================================
  Files         616      616              
  Lines       65295    65295              
==========================================
- Hits        25818    25803      -15     
- Misses      34980    34993      +13     
- Partials     4497     4499       +2     
Impacted Files Coverage Δ
node/modules/client.go 74.03% <100.00%> (ø)
node/modules/graphsync.go 63.15% <100.00%> (ø)
node/modules/storageminer.go 62.50% <100.00%> (ø)
extern/sector-storage/sched_resources.go 75.00% <0.00%> (-9.38%) ⬇️
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
extern/storage-sealing/fsm.go 56.22% <0.00%> (-1.21%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc10281...16973bc. Read the comment docs.

@rvagg
Copy link
Member

rvagg commented Oct 5, 2021

I've done this upgrade on #7427 so this PR shouldn't be necessary now.

@dirkmc
Copy link
Contributor Author

dirkmc commented Oct 5, 2021

Thanks @rvagg, closing this issue in favour of #7427

@dirkmc dirkmc closed this Oct 5, 2021
@Kubuxu Kubuxu deleted the feat/go-fil-markets-v1.13.0 branch November 25, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants