-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: withdraw CLIs should depend on network version #7483
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7483 +/- ##
==========================================
- Coverage 39.23% 39.18% -0.06%
==========================================
Files 631 631
Lines 66853 66866 +13
==========================================
- Hits 26232 26199 -33
- Misses 36054 36093 +39
- Partials 4567 4574 +7
Continue to review full report at Codecov.
|
Co-authored-by: Jiaying Wang <[email protected]>
cli/wallet.go
Outdated
} | ||
|
||
fmt.Printf("Successfully withdrew %s FIL\n", withdrawn) | ||
if withdrawn != amt { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use a function to compare here, otherwise, you are comparing pointers to bigints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK the comparison needs to be explicit instead of via !=
.
Co-authored-by: Jiaying Wang <[email protected]>
Co-authored-by: Jiaying Wang <[email protected]>
Co-authored-by: Jiaying Wang <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Fixes #7445