Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: withdraw CLIs should depend on network version #7483

Merged
merged 7 commits into from
Oct 11, 2021

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Oct 10, 2021

Fixes #7445

@arajasek arajasek requested a review from a team as a code owner October 10, 2021 00:17
@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #7483 (5abba9c) into master (c776811) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7483      +/-   ##
==========================================
- Coverage   39.23%   39.18%   -0.06%     
==========================================
  Files         631      631              
  Lines       66853    66866      +13     
==========================================
- Hits        26232    26199      -33     
- Misses      36054    36093      +39     
- Partials     4567     4574       +7     
Impacted Files Coverage Δ
cli/wallet.go 0.00% <0.00%> (ø)
cmd/lotus-miner/actor.go 7.92% <0.00%> (-0.07%) ⬇️
cmd/lotus-shed/actor.go 0.00% <0.00%> (ø)
chain/actors/builtin/miner/diff.go 52.94% <0.00%> (-5.89%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
miner/warmup.go 76.19% <0.00%> (-4.77%) ⬇️
miner/miner.go 51.65% <0.00%> (-4.31%) ⬇️
chain/stmgr/searchwait.go 66.02% <0.00%> (-2.57%) ⬇️
node/modules/core.go 46.46% <0.00%> (-2.03%) ⬇️
node/repo/memrepo.go 69.50% <0.00%> (-2.00%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c776811...5abba9c. Read the comment docs.

cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cli/wallet.go Show resolved Hide resolved
cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cli/wallet.go Outdated
}

fmt.Printf("Successfully withdrew %s FIL\n", withdrawn)
if withdrawn != amt {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use a function to compare here, otherwise, you are comparing pointers to bigints.

Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the comparison needs to be explicit instead of via !=.

cmd/lotus-miner/actor.go Outdated Show resolved Hide resolved
cli/wallet.go Outdated Show resolved Hide resolved
cmd/lotus-shed/actor.go Outdated Show resolved Hide resolved
Jakub Sztandera and others added 3 commits October 11, 2021 14:03
@Kubuxu Kubuxu enabled auto-merge (squash) October 11, 2021 12:04
Jakub Sztandera added 2 commits October 11, 2021 14:06
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
@jennijuju jennijuju disabled auto-merge October 11, 2021 12:23
@jennijuju jennijuju merged commit c92d733 into master Oct 11, 2021
@jennijuju jennijuju deleted the asr/withdraw-fix branch October 11, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal freezes - (lotus-miner actor withdraw) Receipt hang.
3 participants