Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Use 1M buffers for Tar transfers #7681

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 24, 2021

Should make cross-worker transfers use slightly less CPU (and potentially be faster on 10G+ networks)

@magik6k magik6k requested a review from a team as a code owner November 24, 2021 19:10
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #7681 (8454abc) into master (3714177) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7681      +/-   ##
==========================================
- Coverage   39.60%   39.54%   -0.07%     
==========================================
  Files         635      635              
  Lines       67581    67571      -10     
==========================================
- Hits        26767    26719      -48     
- Misses      36217    36243      +26     
- Partials     4597     4609      +12     
Impacted Files Coverage Δ
extern/sector-storage/stores/http_handler.go 75.28% <33.33%> (+1.69%) ⬆️
extern/sector-storage/tarutil/systar.go 42.10% <50.00%> (-7.90%) ⬇️
extern/sector-storage/stores/remote.go 58.24% <100.00%> (ø)
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-3.93%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3714177...8454abc. Read the comment docs.

@magik6k magik6k merged commit ab55a6f into master Nov 24, 2021
@magik6k magik6k deleted the feat/storage-tar-buf branch November 24, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants