Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update markets stack #7959

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Conversation

hannahhoward
Copy link
Contributor

@hannahhoward hannahhoward commented Jan 15, 2022

This PR updates market stack:

  • go graphsync v0.12.0 with support for UnixFS selectors and additional tracing
  • go-data-transfer v1.13.0 with support for transfers where parts of the DAG are missing, and removal and deprecation of CIDLists/CIDSets and old protocols (major simplification + possible performance boost)
  • outstanding go-fil-markets PR to incorporate and support DAGs where parts are missing -- this needs additional CAR tooling, and the PR needs approval. We also need to decide if we want this for 1.15. If we merge, without, everything will work as intended we just wont get this functionality.

Checklist

Before you mark the PR ready for review, please make sure that:

  • [x ] All commits have a clear commit message.
  • [x ] The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • [ x] This PR has tests for new functionality or change in behaviour
  • [x ] If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • [ x] CI is green

@hannahhoward hannahhoward requested a review from a team as a code owner January 15, 2022 01:09
update go-fil-markets, go-data-transfer 1.13.0, go-graphsync 0.12.0
@hannahhoward hannahhoward force-pushed the feat/update-data-transfer-graphsync branch from 03d3096 to 92d56d8 Compare January 15, 2022 01:21
@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #7959 (1ce1dbb) into master (f628e12) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7959      +/-   ##
==========================================
- Coverage   39.33%   39.21%   -0.13%     
==========================================
  Files         658      658              
  Lines       71142    71136       -6     
==========================================
- Hits        27985    27895      -90     
- Misses      38341    38424      +83     
- Partials     4816     4817       +1     
Impacted Files Coverage Δ
markets/loggers/loggers.go 89.28% <100.00%> (-10.72%) ⬇️
node/modules/client.go 75.24% <100.00%> (+1.20%) ⬆️
node/modules/storageminer.go 63.50% <100.00%> (+0.14%) ⬆️
itests/kit/blockminer.go 74.11% <0.00%> (-17.06%) ⬇️
node/impl/full/mpool.go 25.21% <0.00%> (-8.70%) ⬇️
extern/storage-sealing/sector_state.go 92.30% <0.00%> (-7.70%) ⬇️
chain/actors/builtin/miner/diff.go 52.94% <0.00%> (-5.89%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f628e12...1ce1dbb. Read the comment docs.

go.mod Outdated
github.com/filecoin-project/go-fil-commcid v0.1.0
github.com/filecoin-project/go-fil-commp-hashhash v0.1.0
github.com/filecoin-project/go-fil-markets v1.14.1
github.com/filecoin-project/go-fil-markets v1.14.2-0.20220115005823-180ae44bbc36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a tag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannahhoward context here is just that we're trying to diligently avoid commit deps in lotus because it's breaking a little too often and pissing people off

@magik6k magik6k merged commit 9544209 into master Jan 18, 2022
@magik6k magik6k deleted the feat/update-data-transfer-graphsync branch January 18, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants