Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: api: Api call to get actor cids works for versions < 16 #8941

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Closes #8934

Proposed Changes

StateActorCodeCIDs now works for all network/actors versions.
Added a new API call StateActorManifestCID to get the manifest cid separately to make StateActorCodeCIDs cleaner and more uniform across versions

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner June 28, 2022 16:42
@geoff-vball geoff-vball force-pushed the gstuart/actors-cids-older-versions branch from d43a062 to 10dc957 Compare June 28, 2022 16:52
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #8941 (75c7dde) into release/v1.16.0 (ed735a3) will decrease coverage by 0.77%.
The diff coverage is 67.21%.

❗ Current head 75c7dde differs from pull request most recent head 1da3ca1. Consider uploading reports for the commit 1da3ca1 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.16.0    #8941      +/-   ##
===================================================
- Coverage            41.53%   40.75%   -0.78%     
===================================================
  Files                  698      701       +3     
  Lines                81664    77717    -3947     
===================================================
- Hits                 33916    31671    -2245     
+ Misses               41990    40620    -1370     
+ Partials              5758     5426     -332     
Impacted Files Coverage Δ
api/api_full.go 57.89% <ø> (ø)
api/v0api/full.go 0.00% <ø> (ø)
cli/state.go 1.03% <0.00%> (+<0.01%) ⬆️
node/impl/full/state.go 34.79% <0.00%> (-0.08%) ⬇️
chain/gen/genesis/f00_system.go 60.00% <33.33%> (ø)
chain/gen/genesis/f02_reward.go 62.50% <33.33%> (ø)
chain/gen/genesis/f03_cron.go 62.50% <33.33%> (ø)
chain/gen/genesis/f04_power.go 62.50% <33.33%> (ø)
chain/gen/genesis/f05_market.go 62.50% <33.33%> (ø)
chain/gen/genesis/f06_vreg.go 61.90% <33.33%> (ø)
... and 178 more

@geoff-vball geoff-vball force-pushed the gstuart/actors-cids-older-versions branch from 10dc957 to df1d5d2 Compare June 28, 2022 23:05
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we're doing this big method, we should definitely get rid of the individual methods called GetMultisigActorCodeID (etc.).

chain/actors/actor_cids.go Show resolved Hide resolved
chain/actors/actor_cids.go Outdated Show resolved Hide resolved
node/impl/full/state.go Outdated Show resolved Hide resolved
@geoff-vball geoff-vball force-pushed the gstuart/actors-cids-older-versions branch 2 times, most recently from 378d204 to 1da3ca1 Compare June 29, 2022 17:52
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits, but LGTM!

chain/actors/actor_cids.go Show resolved Hide resolved
chain/actors/manifest.go Outdated Show resolved Hide resolved
@geoff-vball geoff-vball force-pushed the gstuart/actors-cids-older-versions branch from 1da3ca1 to 3613e28 Compare June 29, 2022 18:17
@geoff-vball geoff-vball changed the base branch from release/v1.16.0 to master June 29, 2022 18:18
@geoff-vball geoff-vball force-pushed the gstuart/actors-cids-older-versions branch from 3613e28 to 3079920 Compare June 29, 2022 18:32
@geoff-vball geoff-vball enabled auto-merge June 29, 2022 18:34
@geoff-vball geoff-vball disabled auto-merge June 29, 2022 18:35
@geoff-vball geoff-vball force-pushed the gstuart/actors-cids-older-versions branch from cf62ac5 to 484caff Compare June 29, 2022 19:04
@geoff-vball geoff-vball force-pushed the gstuart/actors-cids-older-versions branch from 484caff to 4bebce0 Compare June 29, 2022 19:16
@geoff-vball geoff-vball enabled auto-merge June 29, 2022 19:28
@geoff-vball geoff-vball merged commit 3bb7e9d into master Jun 29, 2022
@geoff-vball geoff-vball deleted the gstuart/actors-cids-older-versions branch June 29, 2022 19:31
frrist added a commit to filecoin-project/lily that referenced this pull request Jun 29, 2022
- replace with filecoin-project/lotus#8941 when lotus v1.17.0 is cut
frrist added a commit to filecoin-project/lily that referenced this pull request Jul 4, 2022
- replace with filecoin-project/lotus#8941 when lotus v1.17.0 is cut
frrist added a commit to filecoin-project/lily that referenced this pull request Jul 5, 2022
* deps: update to lotus v0.16.0

* refactor: remove unused actor gen code

* chore: update actor code generator for v8

* gen: init actor accessors

* gen: market actor accessors

* gen: multisig actor accessors

* gen: power actor accessors

* gen: reward actor accessors

* gen verifreg actor accessors

* gen: miner actor accessors

* chore: update miner state extractors

- required due to changes in miner actor gen accessors

* chore: update market actor extractors

- required for market actor gen accessors

* gen: builtin accessors

* refactor: remove unused map opts lookup

- actor accessors now return map opt values

* chore: update message test deps

- use v8 actor structs

* feat: add actor CID lookups

- replace with filecoin-project/lotus#8941 when lotus v1.17.0 is cut

* chore: update lens interface to match lotus api

- required due to lotus update v1.16.0

* refactor: register new actor code in processor

* fix: update parsed message extractor with new exitcode

* fix: only init VM for network version prior to 13

- ensures we can process message on FVM upgrade boundary

* Add is_string column to market_deal_proposal model (#1015)

* chore: add is_string column to market_deal_proposal model

* fix: many incorrect pointer equality comparisons (#1018)

* fix: many incorrect pointer equality comparisons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expand StateActorCodeCIDs to support network version <16
2 participants