Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EthGetTransactionCount should not return error #9429

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

ychiaoli18
Copy link
Contributor

@ychiaoli18 ychiaoli18 commented Oct 5, 2022

Proposed Changes

EthGetTransactionCount should not return error and should return 0 when the actor is not found

Ethereum's behavior is not to return errors as long as the address is a valid Ethereum address.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ychiaoli18 ychiaoli18 requested a review from a team as a code owner October 5, 2022 16:28
@ychiaoli18 ychiaoli18 closed this Oct 5, 2022
@ychiaoli18 ychiaoli18 reopened this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants