feat: use f4 eth addresses wherever possible #9532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds on #9531, merge that first. |
vyzo
approved these changes
Oct 21, 2022
| id, err := address.IDFromAddress(addr) | ||
| if err != nil { | ||
| return EthAddress{}, err | ||
| func TryEthAddressFromFilecoinAddress(addr address.Address, allowId bool) (EthAddress, bool, error) { |
There was a problem hiding this comment.
when would we want to not allow ID?
There was a problem hiding this comment.
When we want to check if we have an eth address (take a look at how we use this)
Previously, we'd use embedded ID addresses.
raulk
force-pushed
the
steb/f4-addresses-everywhere
branch
from
e156e73 to
247a5e4
Compare
raulk
approved these changes
Oct 21, 2022
raulk
approved these changes
Oct 21, 2022
vyzo
pushed a commit
that referenced
this pull request
Nov 9, 2022
Co-authored-by: Raúl Kripalani <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd use embedded ID addresses.