feat: Retrieval into remote blockstores #9565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/netretr
branch
6 times, most recently
from
b766e6f to
6c52bfe
Compare
|
Looks like some of the test failures are real |
ZenGround0
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
This seems fine to merge once existing tests stop failing. I also think this would benefit a lot from an integration test that starts up an in process application, runs a retrieval and checks that the external blockstore has all of the state. I think that should not be too hard to make.
magik6k
force-pushed
the
feat/netretr
branch
7 times, most recently
from
8060ee6 to
3545e80
Compare
|
This is going to conflict a little with #9597, will merge this after the big PR lands in master |
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This PR contains lotus-specific parts of #9382
Proposed Changes