Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shed: set control address: add dump bytes option #9572

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

arajasek
Copy link
Contributor

Related Issues

Helps (but does NOT close) #9563

Proposed Changes

Right now, the Filecoin protocol only allows the owner address to set control addresses. Changing this requires a FIP & network upgrade.

Since some owner keys are maintained by folks that don't run Lotus nodes, it might be useful to share the raw bytes of such messages with them, for them to sign offline, and return to someone capable of pushing the signed message to the network. This is imperfect for a few reasons:

  • the entity that has the owner key should confirm the bytes are in fact the message they intend to send
  • the gas estimation is performed at the time this command is run, and may be poor estimation for the time when the message is sent out
  • the worker really should be able to do this.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek merged commit abfabd2 into master Nov 7, 2022
@arajasek arajasek deleted the asr/change-control branch November 7, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants