Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stmgr: bubble up errors properly from ApplyImplicitMessage #9582

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Nov 1, 2022

Related Issues

@simlecode pointed out that the change in #9557 does not properly bubble up some errors because ret can be nil.

Proposed Changes

Bubbles up real errors but allows us to return the call information when the call itself errors.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek merged commit 98c2d25 into release/v1.18.0 Nov 1, 2022
@arajasek arajasek deleted the gstuart/call-fix branch November 1, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants