refactor: sealing: minor refactor of FinalizeReplicaUpdate #9614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
I was investigating #9396, and ran into this confusing piece of code. This PR doesn't actually solve 9396, though.
Proposed Changes
State the condition when we want to move unsealed files more clearly.
I'm still a little unsure of this method. We might want to refresh the value of
moveUnsealed
after we've called intoFinalizeReplicaUpdate
, since that call might delete the unsealed files. But it should only do that whenkeepUnsealed == 0
, so I guess it's fine.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps