Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sealing: minor refactor of FinalizeReplicaUpdate #9614

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Nov 9, 2022

Related Issues

I was investigating #9396, and ran into this confusing piece of code. This PR doesn't actually solve 9396, though.

Proposed Changes

State the condition when we want to move unsealed files more clearly.

I'm still a little unsure of this method. We might want to refresh the value of moveUnsealed after we've called into FinalizeReplicaUpdate, since that call might delete the unsealed files. But it should only do that when keepUnsealed == 0, so I guess it's fine.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner November 9, 2022 14:13
@arajasek arajasek changed the title Sealing manager: minor refactor refactor: sealing: minor refactor of FinalizeReplicaUpdate Nov 9, 2022
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks at least less confusing

@magik6k magik6k merged commit 6104567 into master Nov 11, 2022
@magik6k magik6k deleted the asr/move-unsealed branch November 11, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants