-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add EventsRoot field to message receipt #9624
feat: Add EventsRoot field to message receipt #9624
Conversation
78124c7
to
34433af
Compare
34433af
to
62baa1d
Compare
62baa1d
to
4eb94b5
Compare
@@ -465,7 +465,9 @@ Inputs: | |||
{ | |||
"SealProof": 8, | |||
"SectorNumber": 9, | |||
"SectorKey": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This were a side effect of adding a docs example for the *cid.Cid
type. I'm inclined to keep them even though the CID prefixes may be wrong in some cases. If someone complains, we might have to add CID newtypes to attach specific CID examples to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Staging into feat/nv18-events
.
Related Issues
Part of #9473
Uses filecoin-project/filecoin-ffi#332
Proposed Changes
Follows proposed FIP for actor events
Important changes in
chain/types
:EventsRoot
field toMessageReceipt
Event
andEventEntry
typesAdditional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps