Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add EventsRoot field to message receipt #9624

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

iand
Copy link
Contributor

@iand iand commented Nov 10, 2022

Related Issues

Part of #9473

Uses filecoin-project/filecoin-ffi#332

Proposed Changes

Follows proposed FIP for actor events

Important changes in chain/types:

  • Adds a new EventsRoot field to MessageReceipt
  • Adds new Event and EventEntry types

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@iand iand force-pushed the feat/nv18-rcptevent branch from 78124c7 to 34433af Compare November 10, 2022 12:12
@iand iand changed the title feat: Add Events field to message receipt feat: Add EventsRoot field to message receipt Nov 10, 2022
@iand iand force-pushed the feat/nv18-rcptevent branch from 34433af to 62baa1d Compare November 10, 2022 12:14
@iand iand force-pushed the feat/nv18-rcptevent branch from 62baa1d to 4eb94b5 Compare November 10, 2022 14:50
@@ -465,7 +465,9 @@ Inputs:
{
"SealProof": 8,
"SectorNumber": 9,
"SectorKey": null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This were a side effect of adding a docs example for the *cid.Cid type. I'm inclined to keep them even though the CID prefixes may be wrong in some cases. If someone complains, we might have to add CID newtypes to attach specific CID examples to them.

@raulk raulk changed the base branch from feat/nv18-fevm to feat/nv18-events November 11, 2022 20:24
@raulk raulk marked this pull request as ready for review November 11, 2022 20:24
@raulk raulk requested a review from a team as a code owner November 11, 2022 20:24
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging into feat/nv18-events.

@raulk raulk merged commit 4e7b8d5 into filecoin-project:feat/nv18-events Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants