NV18: FEVM: Basic smoke test

[vyzo]

The basic FEVM smoke test with SimpleCoin.

[arajasek]

Oh no, this test is far too CLI-y and string-matchy for my preference. This is problematic for 2 reasons:

• Such tests are notoriously brittle and lead to future 😿
• Such tests are less useful as "demonstrators" of how things work (what messages are sent, what's returned, etc.)

I think it would be much nicer to actually read the contract bytes, formulate the messages as appropriate, and parse returns with assertions. This will definitely be a more bloated test (much more code), but overall better.

(If we want this as a separate CLI test, just to cover CLI functionality, I'm less opposed to that).

[vyzo]

Basically you want me to copy the cli code ;)

I guess I could do that.

[vyzo]

But yes, we do want to cover cli functionality too.
We have been using this as a smoke test for a long time.

[Stebalien]

But yes, we do want to cover cli functionality too.

That would go in cli/chain_test.go. We usually test the API and CLI separately.

[vyzo]

It is an itest however, and there plenty of cli tests in the itest bundle.

I propose we keep this here and add a second test that does everything by hand.

[arajasek]

It is an itest however, and there plenty of cli tests in the itest bundle.

I propose we keep this here and add a second test that does everything by hand.

Yeah, I don't think there should be, and don't really want more. Here's a good test to use as a model -- it's basically laid out as:

• setup
• push message, assertion
• push message, assertion
• migration (not relevant to this PR), assertion
• push moar messages, moar assertions.

[vyzo]

ok, I rewrote the thing as requested and removed the cli test; I will squash on merge and there will be no sign of it....