Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test and fixes for EthSubscribe #9659

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

iand
Copy link
Contributor

@iand iand commented Nov 16, 2022

Related Issues

Based on feat/nv18-events branch

Proposed Changes

Fixes for EthSubscripton:

  • don't reject subscriptions that have no min height
  • buffer subscription output channel

Refactoring:

  • Make newEthBlockFromFilecoinTipSet, newEthTxReceipt, newEthTxFromFilecoinMessageLookup and lookupEthAddress free standing utility functions

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@iand iand requested a review from a team as a code owner November 16, 2022 15:37
@raulk raulk merged commit 5b4ec7d into filecoin-project:feat/nv18-events Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants