Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: Check upper bound for deal duration #9753

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Proposed Changes

Deal cli wasn't checking upper limit for deals, which was easy to mess up on devnets because of the lower block time.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner November 29, 2022 19:58
@geoff-vball geoff-vball force-pushed the gstuart/fix-devnet-deals branch from b9bb035 to c2e4690 Compare November 29, 2022 20:18
@geoff-vball geoff-vball merged commit 33a176e into master Dec 12, 2022
@geoff-vball geoff-vball deleted the gstuart/fix-devnet-deals branch December 12, 2022 14:33
@jennijuju jennijuju added this to the Network v18 milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants