Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cliutil: Fix URL-based API endpoint parsing #9780

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Dec 2, 2022

Related Issues

Regression from #9294

Proposed Changes

Additional Info

Without this fix FULLNODE_API_INFO=wss://api.chain.love ./lotus daemon --lite wouldn't work

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner December 2, 2022 19:17
@jennijuju
Copy link
Member

backport to v1.19.0 plz

@magik6k magik6k merged commit 1791db5 into master Dec 2, 2022
@magik6k magik6k deleted the fix/parse-api-urls branch December 2, 2022 21:09
@ianconsolata
Copy link
Contributor

How can we add an integration test to make sure we catch this case and prevent a regression from happening again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants