Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_build_: Fix docker deployments #9826

Merged
merged 8 commits into from
Dec 9, 2022
Merged

Conversation

ianconsolata
Copy link
Contributor

Related Issues

This is a p0 update
When I refactored the docker image publishing process earlier, I forgot two critical pieces which broke our docker releases. We haven't pushed any images in the last 11 days as a result, since 1.18.1

  1. I used echo in the publish jobs to sanity check that they were working without publishing new images, and forgot to remove those echo calls when it was merged, meaning none of our docker publish jobs were actually publishing images.
  2. I forgot to also create build / publish jobs for the lotus image, instead only building lotus-all-in-one.

Proposed Changes

In addition to fixing the two issues above, this PR:

  1. Builds and pushes a container on every master merge to the master branch.
  2. Pushes containers to immutable SHA tags in additional to the mutable channel tags (i.e. stable, master, etc)

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ianconsolata ianconsolata requested a review from a team as a code owner December 9, 2022 18:38
@ianconsolata
Copy link
Contributor Author

ianconsolata commented Dec 9, 2022

It looks like the current main branch is currently failing linting and tidy-check so I fixed those as well.

@geoff-vball
Copy link
Contributor

geoff-vball commented Dec 9, 2022

Are the changes to tracer.go and tracer-test.go intentional?

Nevermind, I see you did it for the linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants