Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test: Maybe help with TestMultisigReentrant flakes #9881

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Dec 15, 2022

Related Issues

Probably helps #9880

Proposed Changes

Quiet wdpost logs so logs are actually readable. Add a log for when the trace isn't the right depth that should print the trace.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner December 15, 2022 04:05
@geoff-vball geoff-vball force-pushed the gstuart/multisig-flake branch 2 times, most recently from d4c3fe1 to b3ba605 Compare December 15, 2022 04:12
@geoff-vball geoff-vball force-pushed the gstuart/multisig-flake branch from b3ba605 to 886a286 Compare December 15, 2022 06:06
itests/multisig_test.go Outdated Show resolved Hide resolved
Co-authored-by: Aayush Rajasekaran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants