Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include network when publishing mainnet sha image #9890

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

ianconsolata
Copy link
Contributor

Related Issues

I accidentally left in a parameter in this docker push that will cause it to error. The image generated for Mainnet doesn't use the mainnet suffix, but I left it in there for the SHA publish. This removes it.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ianconsolata ianconsolata requested a review from a team as a code owner December 15, 2022 23:58
@geoff-vball geoff-vball merged commit 1dee884 into master Dec 16, 2022
@geoff-vball geoff-vball deleted the id/fix-docker-sha-push branch December 16, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants