Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement and test the v18 migration #9931

Merged
merged 1 commit into from
Dec 22, 2022
Merged

feat: implement and test the v18 migration #9931

merged 1 commit into from
Dec 22, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Dec 22, 2022 •
edited
Loading

Related Issues

Fixes #9898.
Also addresses half of filecoin-project/ref-fvm#1173.

Proposed Changes

Simple migration that hooks up filecoin-project/go-state-types#142
Needs go-state-types tag after filecoin-project/go-state-types#142 lands

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner December 22, 2022 01:00
@arajasek arajasek force-pushed the asr/migration branch 2 times, most recently from 959eed5 to 755a9fe Compare December 22, 2022 01:09
geoff-vball
geoff-vball approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 2 nits

chain/gen/genesis/fevm.go Outdated Show resolved Hide resolved
itests/migration_nv18_test.go Show resolved Hide resolved
@arajasek arajasek force-pushed the asr/migration branch 2 times, most recently from 87e049e to 856d7e1 Compare December 22, 2022 18:03
@arajasek arajasek mentioned this pull request Dec 22, 2022
Closed
7 tasks
@arajasek arajasek merged commit 336a0e5 into feat/nv18-fevm Dec 22, 2022
@arajasek arajasek deleted the asr/migration branch December 22, 2022 18:24
@simlecode simlecode mentioned this pull request Dec 23, 2022
Merged
6 tasks
@Fatman13 Fatman13 mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoff-vball geoff-vball geoff-vball approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arajasek @geoff-vball