Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eth_blockNumber: make it aware of null rounds. #9934

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

raulk
Copy link
Member

@raulk raulk commented Dec 23, 2022

Related Issues

eth_blockNumber blindly returned the HEAD height - 1. This makes the method aware of null rounds, so it will give the appearance that the chain has paused while null rounds are being produced, and will keep clients from querying for null rounds when blocks don't exist.

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@raulk raulk requested a review from a team as a code owner December 23, 2022 17:41
@raulk raulk merged commit f44bd27 into feat/nv18-fevm Dec 23, 2022
@raulk raulk deleted the raulk/fix-eth-blocknumber-null-rounds branch December 23, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants