Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add renew max-sectors flag #9941

Merged
merged 3 commits into from
Jan 4, 2023
Merged

add renew max-sectors flag #9941

merged 3 commits into from
Jan 4, 2023

Conversation

beck-8
Copy link
Contributor

@beck-8 beck-8 commented Dec 25, 2022

Related Issues

#9940

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@beck-8 beck-8 requested a review from a team as a code owner December 25, 2022 13:07
magik6k
magik6k reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gen check fails because generated cli docs need updating - can be fixed by running make docsgen-cli and committing changes

cmd/lotus-miner/sectors.go Show resolved Hide resolved
cmd/lotus-miner/sectors.go Outdated Show resolved Hide resolved
magik6k
magik6k approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@magik6k magik6k merged commit 273184b into filecoin-project:master Jan 4, 2023
@magik6k magik6k mentioned this pull request Jan 4, 2023
Merged
7 tasks
@beck-8 beck-8 deleted the feat/add_renew_max_sectors branch January 4, 2023 13:47
@Fatman13 Fatman13 mentioned this pull request Jan 9, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beck-8 @magik6k