feat: more ethaccount abstraction tests #9957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisperson
approved these changes
Jan 9, 2023
| require.NoError(t, err) | ||
|
|
||
| msgFromEmbryo.Value = | ||
| abi.TokenAmount(types.MustParseFIL("1000")) |
There was a problem hiding this comment.
nit: can probably be on the same line
arajasek
force-pushed
the
asr/ethaccount-tests
branch
from
174d50a to
35a37ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
filecoin-project/ref-fvm#1327
Proposed Changes
Adds the test cases described in the issue.
Needs filecoin-project/ref-fvm#1355 in an FVM release (and introduced in FFI) for one of the new test cases to 💚
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps