Add new FEVM actors to the registry #9958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
approved these changes
Jan 3, 2023
geoff-vball
reviewed
Jan 3, 2023
magik6k
reviewed
Jan 4, 2023
Comment on lines
+293
to
+296
| if um == nil { | ||
| // TODO: I would like to assert that we have the empty object here | ||
| return nil, nil | ||
| } |
There was a problem hiding this comment.
Do the embryo actors actually not have state? What does the state cid in actor entry point to?
There was a problem hiding this comment.
Embryo actors (soon to be renamed to "placeholders"), EthAccounts, and the EAM do not have state. Their heads are the empty object CID.
This CID will get put into the blockstore as part of the migration (if it isn't already).
There was a problem hiding this comment.
Then I guess, if we’re not using nil state anywhere to mean “actor not found”, this seems fine
There was a problem hiding this comment.
Good question -- I don't know of any place where we do that, but I'll take a look before assuming.
arajasek
force-pushed
the
asr/fevm-registry
branch
from
e1aca24 to
c7ec974
Compare
18 tasks
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Should fix filecoin-project/ref-fvm#1022
Proposed Changes
Additional Info
Needs filecoin-project/go-state-types#143 in a release
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps