feat: add toolshed commands to inspect statetree size #9982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisperson
force-pushed
the
feat/obj-stats
branch
3 times, most recently
from
a5d764e to
b0f5a3e
Compare
travisperson
force-pushed
the
feat/obj-stats
branch
from
b0f5a3e to
2dc3ec2
Compare
ZenGround0
approved these changes
Jan 11, 2023
| // When it comes to fvm / evm actors this method of inspecting fields will probably not work | ||
| // and we may only be able to collect stats for the top level object. We might be able to iterate | ||
| // over the top level fields for the actors and identify field that are CIDs, but unsure if we would | ||
| // be able to identify a field name. |
There was a problem hiding this comment.
You are right about this for M2.2, we'd need some open manifest so that something like DumpActorState gets updated with meaningful field names. For FeVM we use a single builtin actor type to manage all user contracts so this will actually work pretty well, though we'll have the same problem one level down on the user contract code hash.
travisperson
force-pushed
the
feat/obj-stats
branch
from
2dc3ec2 to
1d64607
Compare
travisperson
force-pushed
the
feat/obj-stats
branch
from
1d64607 to
a0c58b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#9793
Proposed Changes
Add two commands
stat-actorandstat-objthat work with an offline lotus repo which report dag size stats.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps