Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address review comments from @magik6k on #9617 #9997

Merged
merged 9 commits into from
Jan 12, 2023

Conversation

raulk
Copy link
Member

@raulk raulk commented Jan 12, 2023

Related Issues

See commit log.

Proposed Changes

See commit log.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

raulk added 8 commits January 12, 2023 18:37
These commands relate to the Filecoin EVM runtime.
The name "eth" is very misleading as it can be confused with
Ethereum support (some kind of bridge or something).
@raulk raulk force-pushed the raulk/review-comments branch from a080b14 to a4fb221 Compare January 12, 2023 18:41
@raulk raulk marked this pull request as ready for review January 12, 2023 19:08
@raulk raulk requested a review from a team as a code owner January 12, 2023 19:08
@raulk raulk merged commit 014d954 into feat/nv18-fevm Jan 12, 2023
@raulk raulk deleted the raulk/review-comments branch January 12, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant