Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth contract testing: Openzeppelin: Contract: Address #1621

Closed
ychiaoli18 opened this issue Jan 31, 2023 · 4 comments
Closed

Eth contract testing: Openzeppelin: Contract: Address #1621

ychiaoli18 opened this issue Jan 31, 2023 · 4 comments
Assignees
@Stebalien
Labels
Kind: Bug Something isn't working OpenZeppelin
Milestone
Pre-Mainnet Launch

Comments

@ychiaoli18
Copy link

CI fails while testing Openzeppelin contracts

Link to CircleCI result

Reproduce Steps

Follow the README to set up the environment

cd ./extern/openzeppelin-contracts
npx hardhat --network test test
@Stebalien
Copy link
Member

Fixed https://app.circleci.com/pipelines/github/filecoin-project/fevm-contract-tests/135/workflows/f81b48c5-6c67-42ea-8354-ab849474036f/jobs/365

@Stebalien Stebalien reopened this Feb 15, 2023
@Stebalien
Copy link
Member

Nvm: https://app.circleci.com/pipelines/github/filecoin-project/fevm-contract-tests/135/workflows/f81b48c5-6c67-42ea-8354-ab849474036f/jobs/365?invite=true#step-126-3404

Stebalien added a commit to filecoin-project/lotus that referenced this issue Feb 15, 2023
@Stebalien
fix: eth: correctly decode EthGetStorageAt output
fb8d166 
We cbor-encode it. Also:

1. Actually use the passed block param.
2. Check if the target actor is an EVM actor to avoid nonsense outputs.

fixes filecoin-project/ref-fvm#1621
Stebalien added a commit to filecoin-project/lotus that referenced this issue Feb 15, 2023
@Stebalien
fix: eth: correctly decode EthGetStorageAt output
909c615 
We cbor-encode it. Also:

1. Actually use the passed block param.
2. Check if the target actor is an EVM actor to avoid nonsense outputs.

fixes filecoin-project/ref-fvm#1621
Stebalien added a commit to filecoin-project/lotus that referenced this issue Feb 15, 2023
@Stebalien
fix: eth: correctly decode EthGetStorageAt output
9ed73e0 
We cbor-encode it. Also:

1. Actually use the passed block param.
2. Check if the target actor is an EVM actor to avoid nonsense outputs.

fixes filecoin-project/ref-fvm#1621
Stebalien added a commit to filecoin-project/lotus that referenced this issue Feb 15, 2023
@Stebalien
fix: eth: correctly decode EthGetStorageAt output
5b03ceb 
We cbor-encode it. Also:

1. Actually use the passed block param.
2. Check if the target actor is an EVM actor to avoid nonsense outputs.

fixes filecoin-project/ref-fvm#1621
@Stebalien Stebalien mentioned this issue Feb 15, 2023
Merged
@Stebalien
Copy link
Member

Turns out we weren't correctly decoding the response when looking up storage slots.

@Stebalien Stebalien added Hint: Likely Fixed Kind: Bug Something isn't working labels Feb 15, 2023
@Stebalien Stebalien self-assigned this Feb 15, 2023
@Stebalien Stebalien added this to the Pre-Mainnet Launch milestone Feb 15, 2023
Stebalien added a commit to filecoin-project/lotus that referenced this issue Feb 17, 2023
@Stebalien
fix: eth: correctly decode EthGetStorageAt output (#10284)
5854d72 
* fix: eth: correctly decode EthGetStorageAt output

We cbor-encode it. Also:

1. Actually use the passed block param.
2. Check if the target actor is an EVM actor to avoid nonsense outputs.

fixes filecoin-project/ref-fvm#1621
@Stebalien
Copy link
Member

Verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
Kind: Bug Something isn't working OpenZeppelin
Projects
None yet
Milestone
Pre-Mainnet Launch
Development

No branches or pull requests
2 participants
@Stebalien @ychiaoli18