Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let integration tests generic over externs #664

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Let integration tests generic over externs #664

merged 3 commits into from
Jul 21, 2022

Conversation

mriise
Copy link
Contributor

@mriise mriise commented Jul 19, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022 •
edited
Loading

Codecov Report

Merging #664 (d779fba) into master (cfbb6b1) will increase coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
+ Coverage   50.08%   51.05%   +0.96%     
==========================================
  Files         120      120              
  Lines        9883     9694     -189     
==========================================
- Hits         4950     4949       -1     
+ Misses       4933     4745     -188
Impacted Files Coverage Δ
ipld/amt/src/node.rs 86.56% <0.00%> (-0.26%) ⬇️
fvm/src/syscalls/mod.rs 0.00% <0.00%> (ø)
fvm/src/kernel/default.rs 15.81% <0.00%> (+1.26%) ⬆️
fvm/src/state_tree.rs 80.76% <0.00%> (+3.38%) ⬆️
fvm/src/machine/default.rs 35.03% <0.00%> (+9.90%) ⬆️
fvm/src/init_actor.rs 87.71% <0.00%> (+10.79%) ⬆️
fvm/src/kernel/blocks.rs 91.56% <0.00%> (+26.04%) ⬆️

@tchataigner
Copy link
Contributor

Thank you for that it's awesome ! Sorry for the delay :( Opened a PR on yours to add mock behavior to those dummies 👍

@tchataigner tchataigner mentioned this pull request Jul 19, 2022
Merged
@mriise
Copy link
Contributor Author

mriise commented Jul 20, 2022

thanks! @tchataigner sorry for the delay as well :\

@mriise mriise requested a review from raulk July 21, 2022 17:18
raulk
raulk approved these changes Jul 21, 2022
View reviewed changes
testing/integration/examples/integration.rs
@@ -50,7 +51,7 @@ pub fn main() {
.unwrap();

// Instantiate machine
tester.instantiate_machine().unwrap();
tester.instantiate_machine(DummyExterns).unwrap();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could do some magic here with a default implementation for the Externs type param, but this is good enough ;-)

@raulk raulk requested a review from tchataigner July 21, 2022 17:26
tchataigner
tchataigner approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@tchataigner tchataigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it does the job ! Thank you for handling it !

@raulk raulk merged commit e9657a7 into filecoin-project:master Jul 21, 2022
Stebalien pushed a commit that referenced this pull request Aug 29, 2022
@mriise @Stebalien
Let integration tests generic over externs (#664)
0bb5359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchataigner tchataigner tchataigner approved these changes

@raulk raulk raulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mriise @codecov-commenter @tchataigner @raulk